From: "Luiz Fernando N. Capitulino" <lcapitulino@conectiva.com.br>
To: marcelo.tosatti@cyclades.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2.4] - Fixes bug in fs/ext3/super.c.
Date: Mon, 30 Aug 2004 12:47:24 -0300 [thread overview]
Message-ID: <20040830124724.5f9b2f8e.lcapitulino@conectiva.com.br> (raw)
Hi Marcelo,
Some time ago I fixed this bug in 2.6.
There is a `return NULL' missing in ext3_get_journal() if the
call to journal_init_inode() fail. Note that if the error happens,
`journal' will be NULL and used.
(agains't 2.4.28-pre2).
Signed-off-by: Luiz Capitulino <lcapitulino@conectiva.com.br>
diff -Nparu a/fs/ext3/super.c a~/fs/ext3/super.c
--- a/fs/ext3/super.c 2004-08-07 20:26:05.000000000 -0300
+++ a~/fs/ext3/super.c 2004-08-15 22:18:18.000000000 -0300
@@ -1302,6 +1302,7 @@ static journal_t *ext3_get_journal(struc
if (!journal) {
printk(KERN_ERR "EXT3-fs: Could not load journal inode\n");
iput(journal_inode);
+ return NULL;
}
ext3_init_journal_params(EXT3_SB(sb), journal);
return journal;
--
Luiz Fernando Capitulino
next reply other threads:[~2004-08-30 16:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-30 15:47 Luiz Fernando N. Capitulino [this message]
2004-08-31 10:56 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040830124724.5f9b2f8e.lcapitulino@conectiva.com.br \
--to=lcapitulino@conectiva.com.br \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®