mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: viro@parcelfarce.linux.theplanet.co.uk
To: John Cherry <cherry@osdl.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: 47 New compile/sparse warnings (over the weekend)
Date: Mon, 30 Aug 2004 19:29:29 +0100	[thread overview]
Message-ID: <20040830182929.GK16297@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <1093887916.2653.10.camel@cherrybomb.pdx.osdl.net>

On Mon, Aug 30, 2004 at 10:45:16AM -0700, John Cherry wrote:
> drivers/scsi/megaraid/...
<tons>

Would it be too much to ask people run make C=1 before submitting?

[snip]

> sound/usb/usx2y/usX2Yhwdep.c:218:6: warning: incorrect type in

... piece of shit code.  Already fixed in a patch submitted to Linus.
And no, lack of annotations was not the worst part of it.

      reply	other threads:[~2004-08-30 18:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-30 17:45 John Cherry
2004-08-30 18:29 ` viro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040830182929.GK16297@parcelfarce.linux.theplanet.co.uk \
    --to=viro@parcelfarce.linux.theplanet.co.uk \
    --cc=cherry@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®