mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@osdl.org>, Andy Kleen <ak@suse.de>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [patch] lazy I/O bitmap copy for i386 (ver 2) ...
Date: Tue, 31 Aug 2004 14:06:11 +0200	[thread overview]
Message-ID: <20040831120611.GA14466@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.58.0408241113370.2026@bigblue.dev.mdolabs.com>


* Davide Libenzi <davidel@xmailserver.org> wrote:

> The following patch implements the lazy I/O bitmap copy for the i386
> architecture. It uses an invalid bitmap offset inside the TSS to
> eventually handle the correct bitmap update in the GPF handler. The
> logic is the same of the first version, plus the usage of
> get/put_cpu() (thx Brian) and the nesting over the latest Ingo
> variable bitmap bits.

your patch looks good to me. I believe the killer argument is what you
mentioned previously, that a single GFP is cheaper than a single I/O op,
so even the worst-case (an I/O app doing precisely one I/O op during its
scheduling atom - very unlikely) shouldnt degrade all that much. The
patch is a speedup in every other case.

Signed-off-by: Ingo Molnar <mingo@elte.hu>

	Ingo

      parent reply	other threads:[~2004-08-31 12:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-24 18:20 Davide Libenzi
2004-08-24 20:04 ` Davide Libenzi
2004-08-31 12:06 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040831120611.GA14466@elte.hu \
    --to=mingo@elte.hu \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=davidel@xmailserver.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®