From: Christoph Hellwig <hch@infradead.org>
To: Ian Romanick <idr@us.ibm.com>
Cc: Dave Jones <davej@redhat.com>, Dave Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org
Subject: Re: [rfc][patch] DRM initial function table support.
Date: Tue, 31 Aug 2004 18:01:29 +0100 [thread overview]
Message-ID: <20040831180129.A23112@infradead.org> (raw)
In-Reply-To: <4134A22F.7000103@us.ibm.com>; from idr@us.ibm.com on Tue, Aug 31, 2004 at 09:07:11AM -0700
On Tue, Aug 31, 2004 at 09:07:11AM -0700, Ian Romanick wrote:
> I think the intention is to have default functions set in the
> device-independent code and have the device-dependent code over-ride
> them. Since the defaults may not always be NULL, doing a struct like
> that wouldn't really work. I suppose we could have a struct and a
> device-independent function that copies the non-NULL pointers from the
> per-device struct. Would that be better?
Don't copy them. Just put
if (foo->ops->method1)
foo->ops->method1(args);
else
generic_method1(args);
in your code. It's an additional branch, but you avoid the indirect
functioncalloverhead in exchange.
next prev parent reply other threads:[~2004-08-31 17:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-31 13:11 Dave Airlie
2004-08-31 15:20 ` Dave Jones
2004-08-31 16:07 ` Ian Romanick
2004-08-31 17:01 ` Christoph Hellwig [this message]
2004-08-31 17:52 ` Ian Romanick
2004-08-31 23:39 ` Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040831180129.A23112@infradead.org \
--to=hch@infradead.org \
--cc=airlied@linux.ie \
--cc=davej@redhat.com \
--cc=idr@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®