From: Anton Blanchard <anton@samba.org>
To: akpm@osdl.org
Cc: paulus@samba.org, linux-kernel@vger.kernel.org
Subject: [PATCH] [ppc64] Print backtrace in EEH code
Date: Wed, 1 Sep 2004 22:51:00 +1000 [thread overview]
Message-ID: <20040901125100.GQ26072@krispykreme> (raw)
Hi,
We should print a stack backtrace when we get EEH errors, it makes
debugging the cause of the fail easier.
Anton
Signed-off-by: Anton Blanchard <anton@samba.org>
===== eeh.c 1.29 vs edited =====
--- 1.29/arch/ppc64/kernel/eeh.c Mon Aug 23 18:14:40 2004
+++ edited/eeh.c Mon Aug 30 09:02:41 2004
@@ -447,6 +447,10 @@
spin_unlock_irqrestore(&slot_errbuf_lock, flags);
+ printk(KERN_ERR "EEH: MMIO failure (%d) on device:%s %s\n",
+ rets[0], pci_name(dev), pci_pretty_name(dev));
+ WARN_ON(1);
+
/*
* XXX We should create a separate sysctl for this.
*
@@ -454,14 +458,11 @@
* the system in light of potential corruption, we
* can use it here.
*/
- if (panic_on_oops) {
+ if (panic_on_oops)
panic("EEH: MMIO failure (%d) on device:%s %s\n",
rets[0], pci_name(dev), pci_pretty_name(dev));
- } else {
+ else
__get_cpu_var(ignored_failures)++;
- printk(KERN_INFO "EEH: MMIO failure (%d) on device:%s %s\n",
- rets[0], pci_name(dev), pci_pretty_name(dev));
- }
} else {
__get_cpu_var(false_positives)++;
}
reply other threads:[~2004-09-01 12:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040901125100.GQ26072@krispykreme \
--to=anton@samba.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®