mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: nickpiggin@yahoo.com.au, linux-kernel@vger.kernel.org
Subject: Bug in init_sched_build_groups?
Date: Fri, 3 Sep 2004 15:46:04 +0200	[thread overview]
Message-ID: <20040903134604.GA3374@mschwid3.boeblingen.de.ibm.com> (raw)

Hi Nick,
I stumbled over a problem in the sched_domain code in regard to
zSeries (s390). The problem seems to have been introduced by
ChangeSet 1.1837.3.11: [PATCH] sched: consolidate sched domains.
With z/VM it is possible to start with a small set of cpus and
later on add more if you need them. If I try to online one of
the "late" cpus the scheduler crashes in find_busiest group
because the sched_group for the late cpu is not in the linked
list of sched_groups (group->next is NULL at sched.c:4770).
I worked around that problem with the attached patch. Dunno if
this is the right way to do it but it works for me.

blue skies,
  Martin.

diffstat:
 kernel/sched.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -urN linux-2.6/kernel/sched.c linux-2.6-s390/kernel/sched.c
--- linux-2.6/kernel/sched.c	Fri Sep  3 15:26:17 2004
+++ linux-2.6-s390/kernel/sched.c	Fri Sep  3 15:26:26 2004
@@ -4358,7 +4358,7 @@
 	cpumask_t covered = CPU_MASK_NONE;
 	int i;
 
-	for_each_cpu_mask(i, span) {
+	for_each_cpu_mask(i, cpu_possible_map) {
 		int group = group_fn(i);
 		struct sched_group *sg = &groups[group];
 		int j;

                 reply	other threads:[~2004-09-03 13:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040903134604.GA3374@mschwid3.boeblingen.de.ibm.com \
    --to=schwidefsky@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®