Re: [PATCH,RFC 2.6.9-rc1 2/2] zlib_inflate: Add __BOOTER__ around zlib_inflate_trees_fixed(...)

[Tom Rini <trini@kernel.crashing.org>]

On Thu, Sep 02, 2004 at 06:45:20PM -0700, Tom Rini wrote:

> On Fri, Sep 03, 2004 at 11:14:34AM +1000, Paul Mackerras wrote:
> 
> > Tom Rini writes:
> > 
> > > This is the second part of what I found.  zlib_inflate_trees_fixed(...)
> > > isn't called in decompressing a kernel.  Dropping this, and the call to
> > 
> > I think it is just luck that gzip hasn't used the fixed table in
> > compressing the kernel.  I don't think we have any guarantee that gzip
> > won't use the fixed table.
> 
> That is a good point.  Looking at arch/ppc/boot/lib/zlib.c it generates
> the table, instead of having a static one.  So perhaps we should move to
> that instead for lib/zlib_inflate ?

I've moved lib/zlib_inflate over to generating the table.  But, in
trying to test it, I haven't been able to find anything that will
actually use this (it appears that using this static table was something
that pkzip introduced long ago as an alternative method of good
compression / speed) so I can't actually test it.  But the image size is
back in line.

-- 
Tom Rini
http://gate.crashing.org/~trini/