From: Andrew Morton <akpm@osdl.org>
To: jhf@rivenstone.net (Joseph Fannin)
Cc: albert_herranz@yahoo.es, roland@redhat.com,
linux-kernel@vger.kernel.org, benh@kernel.crashing.org
Subject: Re: 2.6.9-rc1-mm1 ppc build broken
Date: Sun, 5 Sep 2004 14:53:55 -0700 [thread overview]
Message-ID: <20040905145355.0cf48d5c.akpm@osdl.org> (raw)
In-Reply-To: <20040904203715.GA3049@samarkand.rivenstone.net>
jhf@rivenstone.net (Joseph Fannin) wrote:
>
> > The #include <asm/io.h> comes from bk-ia64.patch time
> > interpolation logic patch from Cristoph Lameter.
> >
> > I've checked that at least for the embedded port I'm
> > working on the linux/mm.h is *not* a must on ppc
> > asm/io.h so we can get rid of it (commented out).
> > Maybe this is also true for the rest of ppc platforms.
> >
> > Now 2.6.9-rc1-mm1 builds fine.
>
> This is still broken in -mm3. This fix works for my powermac too,
> except that arch/ppc/syslib/open_pic.c misses errno.h when it does not
> get it through mm.h. I can't speak for other platforms, but I'll
> include the patch.
OK, now I have an ordering problem. If I understand you correctly, this
patch fixes a ppc problem which was introduced by a patch from the bk-ia64
tree, yes?
If so, my options are to ask Tony to add this patch to the bk-ia64 tree so
they all go in at the same time, or to merge this patch into Linus's tree
prior to the ia64 patch. To do the latter, I'd need confirmation that your
patch is safe against current -linus. Can you please confirm this?
--- 25/arch/ppc/syslib/open_pic.c~ppc-build-fix 2004-09-05 14:50:54.250084104 -0700
+++ 25-akpm/arch/ppc/syslib/open_pic.c 2004-09-05 14:50:54.266081672 -0700
@@ -16,6 +16,7 @@
#include <linux/irq.h>
#include <linux/interrupt.h>
#include <linux/sysdev.h>
+#include <linux/errno.h>
#include <asm/ptrace.h>
#include <asm/signal.h>
#include <asm/io.h>
diff -puN include/asm-ppc/io.h~ppc-build-fix include/asm-ppc/io.h
--- 25/include/asm-ppc/io.h~ppc-build-fix 2004-09-05 14:50:54.262082280 -0700
+++ 25-akpm/include/asm-ppc/io.h 2004-09-05 14:50:54.276080152 -0700
@@ -4,7 +4,6 @@
#include <linux/config.h>
#include <linux/types.h>
-#include <linux/mm.h>
#include <asm/page.h>
#include <asm/byteorder.h>
_
next prev parent reply other threads:[~2004-09-05 21:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-30 23:41 Albert Herranz
2004-08-30 23:48 ` Roland McGrath
2004-08-31 10:51 ` Albert Herranz
2004-09-04 20:37 ` Joseph Fannin
2004-09-05 21:53 ` Andrew Morton [this message]
2004-09-06 1:43 ` Joseph Fannin
2004-09-06 11:59 ` Albert Herranz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040905145355.0cf48d5c.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=albert_herranz@yahoo.es \
--cc=benh@kernel.crashing.org \
--cc=jhf@rivenstone.net \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®