mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Adam J. Richter" <adam@yggdrasil.com>
To: janitor@sternwelten.at
Cc: linux-kernel@vger.kernel.org, pgmdsg@ibi.com
Subject: [patch 2.6.9-rc1-bk11] riscom8: previous patch did not compile
Date: Sun, 5 Sep 2004 11:57:30 -0700	[thread overview]
Message-ID: <200409051857.i85IvUt06042@freya.yggdrasil.com> (raw)

	linux-2.6.9-rc1-bk11/drivers/char/riscom8.c added
the patch "drivers/char/riscom8.c MIN/MAX removal", which
had a typo where one of the new min_t() calls is missing the
type parameter.  Because both of the parameters and the result
are all explicitly declared int on all architectures, I changed
it to use min() rather than min_t(int, ...).

	This is the third patch in bk11 that never could have compiled
anywhere.  Although I am glad to see patches being integrated into the
stock kernel more quickly, I would ask each submitter either

	(1) check that the patch being submitted has compiled somewhere, or
	(2) mention in the submission when this has not been done.

Signed-off-by: Adam J. Richter <adam@yggdrasil.com>
                    __     ______________ 
Adam J. Richter        \ /
adam@yggdrasil.com      | g g d r a s i l

--- linux-2.6.9-rc1-bk11/drivers/char/riscom8.c	2004-09-05 09:11:24.000000000 -0700
+++ linux/drivers/char/riscom8.c	2004-09-05 11:35:58.000000000 -0700
@@ -1174,8 +1174,8 @@
 			}
 
 			cli();
-			c = min_t(c, min(SERIAL_XMIT_SIZE - port->xmit_cnt - 1,
-					 SERIAL_XMIT_SIZE - port->xmit_head));
+			c = min(c, min(SERIAL_XMIT_SIZE - port->xmit_cnt - 1,
+				       SERIAL_XMIT_SIZE - port->xmit_head));
 			memcpy(port->xmit_buf + port->xmit_head, tmp_buf, c);
 			port->xmit_head = (port->xmit_head + c) & (SERIAL_XMIT_SIZE-1);
 			port->xmit_cnt += c;

                 reply	other threads:[~2004-09-05  4:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200409051857.i85IvUt06042@freya.yggdrasil.com \
    --to=adam@yggdrasil.com \
    --cc=janitor@sternwelten.at \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pgmdsg@ibi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®