mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Kirill Korotaev <dev@sw.ru>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] removes unnessary print of space
Date: Mon, 6 Sep 2004 01:29:39 -0700	[thread overview]
Message-ID: <20040906012939.65e63521.akpm@osdl.org> (raw)
In-Reply-To: <413C211D.9010301@sw.ru>

Kirill Korotaev <dev@sw.ru> wrote:
>
> I've noticed another thing. There is a default bust_spinlocks() in 
>  lib/bust_spinlocks.c. 4 architectures including x86 have their own 
>  copies of it, which are exactly the same as the default one.
> 
>  So do we really need lib/bust_spinlocks.c or we can move a signle copy 
>  of this function to kernel/printk.c?

I'd leave it as is - nobody's complaining.

In the more modern scheme of things we'd move that file to kernel/ and
require that per-arch Kconfigs define CONFIG_NEED_GENERIC_BUST_SPINLOCKS,
then use that in kernel/Makefile.  But doing that now would be gratuitous
noise, IMO.


  reply	other threads:[~2004-09-06  8:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-06  7:07 Kirill Korotaev
2004-09-06  7:08 ` Andrew Morton
2004-09-06  8:34   ` Kirill Korotaev
2004-09-06  8:29     ` Andrew Morton [this message]
2004-09-06 16:33     ` Randy.Dunlap
2004-09-06 12:17   ` Chris Wedgwood
2004-09-06  7:57 ` Kalin KOZHUHAROV
2004-09-06  9:03   ` Tonnerre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040906012939.65e63521.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=dev@sw.ru \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®