From: "David S. Miller" <davem@davemloft.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: util@deuroconsult.ro, netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Trivial fix for out of bounds array access in xfrm4_policy_check
Date: Tue, 7 Sep 2004 14:02:45 -0700 [thread overview]
Message-ID: <20040907140245.675b7240.davem@davemloft.net> (raw)
In-Reply-To: <E1C4fMc-000817-00@gondolin.me.apana.org.au>
On Tue, 07 Sep 2004 22:46:22 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Catalinux aka Dino BOIE <util@deuroconsult.ro> wrote:
> >
> > Coverity found a bug in accessing xfrm4_policy_check using XFRM_POLICY_FWD
> > (=2) as index in sk->sk_policy.
> >
> > sk->sk_policy[] is defined in sock.h as:
> >
> > struct xfrm_policy *sk_policy[2];
> >
> > Attached is the fix.
>
> This is bogus as if the packet is forwarded then sk == NULL.
Agreed.
prev parent reply other threads:[~2004-09-07 21:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-07 10:35 Catalin(ux aka Dino) BOIE
2004-09-07 12:46 ` Herbert Xu
2004-09-07 21:02 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040907140245.675b7240.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=util@deuroconsult.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®