From: Duncan Sands <baldrick@free.fr>
To: mpm@selenic.com
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] netpoll endian fixes
Date: Wed, 8 Sep 2004 01:24:43 +0200 [thread overview]
Message-ID: <200409080124.43530.baldrick@free.fr> (raw)
The big-endians took their revenge in netpoll.c: on i386,
the ip header length / version nibbles need to be the other
way round; and the htonl leaves only zeros in tot_len...
All the best,
Duncan.
--- linux-2.5/net/core/netpoll.c.orig 2004-09-08 01:15:22.000000000 +0200
+++ linux-2.5/net/core/netpoll.c 2004-09-08 01:05:33.000000000 +0200
@@ -22,6 +22,7 @@
#include <net/tcp.h>
#include <net/udp.h>
#include <asm/unaligned.h>
+#include <asm/byteorder.h>
/*
* We maintain a small pool of fully-sized skbs, to make sure the
@@ -242,9 +243,13 @@
iph = (struct iphdr *)skb_push(skb, sizeof(*iph));
/* iph->version = 4; iph->ihl = 5; */
+#if defined(__LITTLE_ENDIAN_BITFIELD)
+ put_unaligned(0x45, (unsigned char *)iph);
+#else
put_unaligned(0x54, (unsigned char *)iph);
+#endif
iph->tos = 0;
- put_unaligned(htonl(ip_len), &(iph->tot_len));
+ put_unaligned(htons(ip_len), &(iph->tot_len));
iph->id = 0;
iph->frag_off = 0;
iph->ttl = 64;
next reply other threads:[~2004-09-07 23:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-07 23:24 Duncan Sands [this message]
2004-09-07 23:29 ` Matt Mackall
2004-09-08 6:56 ` Duncan Sands
2004-09-07 23:57 ` Matt Mackall
2004-09-08 10:01 ` Duncan Sands
2004-09-08 22:53 ` Matt Mackall
2004-09-09 9:31 ` Duncan Sands
[not found] <77423609@toto.iv>
2004-09-09 2:09 ` Peter Chubb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200409080124.43530.baldrick@free.fr \
--to=baldrick@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome