From: Olaf Hering <olh@suse.de>
To: Tom Rini <trini@kernel.crashing.org>, linux-kernel@vger.kernel.org
Subject: [PATCH] CONFIG_CMDLINE broken on ppc
Date: Wed, 8 Sep 2004 15:40:28 +0200 [thread overview]
Message-ID: <20040908134028.GB15209@suse.de> (raw)
CONFIG_CMDLINE can not work on ppc.
machine_init() copies the string to cmd_line, then platform_init() is
called. It truncates the string to length zero.
--- ./arch/ppc/kernel/setup.c.kaputt 2004-09-08 14:23:36.000000000 +0200
+++ ./arch/ppc/kernel/setup.c 2004-09-08 15:30:42.000000000 +0200
@@ -418,7 +418,9 @@ platform_init(unsigned long r3, unsigned
* are used for initrd_start and initrd_size,
* otherwise they contain 0xdeadbeef.
*/
+#if 0
cmd_line[0] = 0;
+#endif
if (r3 >= 0x4000 && r3 < 0x800000 && r4 == 0) {
strlcpy(cmd_line, (char *)r3 + KERNELBASE,
sizeof(cmd_line));
--
USB is for mice, FireWire is for men!
sUse lINUX ag, nÜRNBERG
next reply other threads:[~2004-09-08 14:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-08 13:40 Olaf Hering [this message]
2004-09-08 13:52 ` Tom Rini
2004-09-08 14:03 ` Olaf Hering
2004-09-08 14:18 ` Tom Rini
2004-09-08 15:18 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040908134028.GB15209@suse.de \
--to=olh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®