From: "David S. Miller" <davem@davemloft.net>
To: Herbert Poetzl <herbert@13thfloor.at>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: 2.6.9-rc1-bk16: DHCPACK, compile time error ...
Date: Thu, 9 Sep 2004 08:49:51 -0700 [thread overview]
Message-ID: <20040909084951.41ef2288.davem@davemloft.net> (raw)
In-Reply-To: <20040909141403.GD14891@MAIL.13thfloor.at>
On Thu, 9 Sep 2004 16:14:04 +0200
Herbert Poetzl <herbert@13thfloor.at> wrote:
> net/ipv4/ipconfig.c:969: error: `i' undeclared (first use in this function)
> net/ipv4/ipconfig.c:969: error: (Each undeclared identifier is reported only once
> net/ipv4/ipconfig.c:969: error: for each function it appears in.)
Already fixed in my tree like so, on it's way to Linus:
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/09/08 17:38:20-07:00 peter@pantasys.com
# [IPV4]: Fix DHCPACK checking in ipconfig.c
#
# Signed-off-by: Peter Buckingham <peter@pantasys.com>
# Signed-off-by: David S. Miller <davem@davemloft.net>
#
# net/ipv4/ipconfig.c
# 2004/09/08 17:37:44-07:00 peter@pantasys.com +1 -3
# [IPV4]: Fix DHCPACK checking in ipconfig.c
#
diff -Nru a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
--- a/net/ipv4/ipconfig.c 2004-09-09 08:31:35 -07:00
+++ b/net/ipv4/ipconfig.c 2004-09-09 08:31:35 -07:00
@@ -966,9 +966,7 @@
break;
case DHCPACK:
- for (i = 0; (dev->dev_addr[i] == b->hw_addr[i])
- && (i < dev->addr_len); i++);
- if (i < dev->addr_len)
+ if (memcmp(dev->dev_addr, b->hw_addr, dev->addr_len) != 0)
goto drop_unlock;
/* Yeah! */
prev parent reply other threads:[~2004-09-09 15:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-09 14:14 Herbert Poetzl
2004-09-09 15:49 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040909084951.41ef2288.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=herbert@13thfloor.at \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome