From: "David S. Miller" <davem@davemloft.net>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: akpm@osdl.org, torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ppc: fix sungem NAPI
Date: Thu, 9 Sep 2004 22:12:44 -0700 [thread overview]
Message-ID: <20040909221244.0d0a91db.davem@davemloft.net> (raw)
In-Reply-To: <1094788157.2543.111.camel@gaston>
On Fri, 10 Sep 2004 13:49:17 +1000
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> The recent sungem NAPI change introduced a bug: dev_kfree_skb() is called
> within the spinlock, thus triggers all sort of WARN_ON's later on down the
> stack.
>
> This patch changes it to dev_kfree_skb_any(), I hope that is fine
> as we aren't really in interrupt, are we ? (I don't know in what
> context NAPI polling occurs, is it a timer IRQ ?)
NAPI polling occurs from softirq context.
Thanks for making me aware of this. This fix is fine for
now, but it may be possible to simplify it and I'll look
into that.
prev parent reply other threads:[~2004-09-10 5:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-10 3:49 Benjamin Herrenschmidt
2004-09-10 5:12 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040909221244.0d0a91db.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome