mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: Roland McGrath <roland@redhat.com>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix sigqueue accounting for posix-timers broken by new RLIMIT_SIGPENDING tracking code
Date: Thu, 9 Sep 2004 23:49:00 -0700	[thread overview]
Message-ID: <20040909234900.Q1973@build.pdx.osdl.net> (raw)
In-Reply-To: <200409100510.i8A5AVD7025919@magilla.sf.frob.com>; from roland@redhat.com on Thu, Sep 09, 2004 at 10:10:31PM -0700

* Roland McGrath (roland@redhat.com) wrote:
> 
> The introduction of RLIMIT_SIGPENDING and the associated tracking code was
> broken for the case of preallocated sigqueue elements, i.e. posix-timers.
> It wrongly includes the timer's preallocated sigqueue structs in the count
> towards the per-user when allocating them, but (rightly) does not decrement
> the count when they are freed.  

Are you sure?  IOW, are you seeing a leak of the count?  The sigqueue
structure has a lifetime the same as the timer, IIRC.  So each time the
signal is sent/received there's no accounting, because it's reused.
But timer create/delete does sigqueue_alloc -> __sigqueue_alloc which
does the inc. and sigqueue_free -> __sigqueue_free which does the dec.
I'm fairly sure I had tested this.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net

  reply	other threads:[~2004-09-10  6:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-10  5:10 Roland McGrath
2004-09-10  6:49 ` Chris Wright [this message]
2004-09-10 17:42   ` Chris Wright
2004-09-10 19:24     ` Roland McGrath
2004-09-10 19:34       ` Chris Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040909234900.Q1973@build.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®