mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Alex Riesen <fork0@users.sourceforge.net>,
	"David S. Miller" <davem@davemloft.net>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, netdev@oss.sgi.com
Subject: Re: 2.6.9-rc1+bk: assertion tcp_get_pcount failed at net/ipv4/tcp_input.c
Date: Fri, 10 Sep 2004 13:30:55 +1000	[thread overview]
Message-ID: <20040910033055.GA26790@gondor.apana.org.au> (raw)
In-Reply-To: <20040909111233.GA3987@steel.home>

[-- Attachment #1: Type: text/plain, Size: 841 bytes --]

On Thu, Sep 09, 2004 at 11:12:33AM +0000, Alex Riesen wrote:
> The box froze after being left for some time (some 10 hours) unattended.
> The only thing in I could find in logs was:
> 
> Sep  8 22:30:18 steel kernel: KERNEL: assertion ((int)tcp_get_pcount(&tp->lost_out) >= 0) failed at net/ipv4/tcp_input.c (2422)
> Sep  8 22:30:18 steel kernel: Leak l=4294967295 4

Looks like the factor isn't set early enough.  Can you please check
that you had the changeset titled

[TCP]: Make sure SKB tso factor is setup early enough.

from davem?

If you did, then please apply the following patch and tell us what
the resulting messages.
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[-- Attachment #2: p --]
[-- Type: text/plain, Size: 523 bytes --]

===== include/net/tcp.h 1.87 vs edited =====
--- 1.87/include/net/tcp.h	2004-09-10 01:51:02 +10:00
+++ edited/include/net/tcp.h	2004-09-10 13:24:25 +10:00
@@ -30,6 +30,7 @@
 #include <linux/slab.h>
 #include <linux/cache.h>
 #include <linux/percpu.h>
+#include <linux/rtnetlink.h>
 #include <net/checksum.h>
 #include <net/sock.h>
 #include <net/snmp.h>
@@ -1195,6 +1196,7 @@
  */
 static inline int tcp_skb_pcount(struct sk_buff *skb)
 {
+	BUG_TRAP(TCP_SKB_CB(skb)->tso_factor);
 	return TCP_SKB_CB(skb)->tso_factor;
 }
 

  reply	other threads:[~2004-09-10  3:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-09 11:12 Alex Riesen
2004-09-10  3:30 ` Herbert Xu [this message]
2004-09-10  5:25   ` David S. Miller
2004-09-10  5:56     ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040910033055.GA26790@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=davem@davemloft.net \
    --cc=fork0@users.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®