From: viro@parcelfarce.linux.theplanet.co.uk
To: Linux Kernel List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] Fix DHCP ipconfig.c
Date: Fri, 10 Sep 2004 11:46:58 +0100 [thread overview]
Message-ID: <20040910104658.GN23987@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20040910104515.A22599@flint.arm.linux.org.uk>
On Fri, Sep 10, 2004 at 10:45:15AM +0100, Russell King wrote:
> bk-curr seems to be a little sick here:
>
> CC net/ipv4/ipconfig.o
> net/ipv4/ipconfig.c: In function `ic_bootp_recv':
> net/ipv4/ipconfig.c:969: error: `i' undeclared (first use in this function)
> net/ipv4/ipconfig.c:969: error: (Each undeclared identifier is reported only once
> net/ipv4/ipconfig.c:969: error: for each function it appears in.)
>
> and here's the medicine:
And here's better one:
diff -urN RC9-rc1-bk16-base/net/ipv4/ipconfig.c RC9-rc1-bk16-current/net/ipv4/ipconfig.c
--- RC9-rc1-bk16-base/net/ipv4/ipconfig.c 2004-09-10 02:13:24.000000000 -0400
+++ RC9-rc1-bk16-current/net/ipv4/ipconfig.c 2004-09-10 03:40:10.000000000 -0400
@@ -966,9 +966,7 @@
break;
case DHCPACK:
- for (i = 0; (dev->dev_addr[i] == b->hw_addr[i])
- && (i < dev->addr_len); i++);
- if (i < dev->addr_len)
+ if (memcmp(b->hw_addr, dev->dev_addr, dev->addr_len) != 0)
goto drop_unlock;
/* Yeah! */
prev parent reply other threads:[~2004-09-10 10:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-10 9:45 Russell King
2004-09-10 10:46 ` viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040910104658.GN23987@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®