mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wedgwood <cw@f00f.org>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] i386 reduce spurious interrupt noise
Date: Fri, 10 Sep 2004 16:10:52 -0700	[thread overview]
Message-ID: <20040910231052.GA3078@taniwha.stupidest.org> (raw)
In-Reply-To: <Pine.LNX.4.58L.0409102306420.20057@blysk.ds.pg.gda.pl>

On Fri, Sep 10, 2004 at 11:23:20PM +0200, Maciej W. Rozycki wrote:

> > -	printk (KERN_INFO "APIC error on CPU%d: %02lx(%02lx)\n",
> > +	printk (KERN_DEBUG "APIC error on CPU%d: %02lx(%02lx)\n",

> This should probably be KERN_ERR even.  This is a serious condition -- if
> you ever get such a message, then inter-APIC messages get corrupted and
> this affects system's stability.

These messages are very common on many platforms, infrequent (once
very few days to twice a day at most in my observations) and seemingly
harmless.

I agree that if you get *many* of these certainly that would indicate
there is a problem but I've not not heard a single instance of this
and if that is the case we need to deal with it differently.

> > -			printk("spurious 8259A interrupt: IRQ%d.\n", irq);
> > +			printk(KERN_DEBUG "spurious 8259A interrupt: IRQ%d.\n", irq);

> You may ever get a single message per system boot from this line.

Sometimes as boot, though often in my experience several minutes after
boot.

> It encourages to have a look at the ERR counter in /proc/interrupts
> to check for possible problems, though admittedly the suggestion
> isn't especially clear.

I think in *both* cases we want to detect a largish (more than 1 ever
n seconds or so) number of these and then complain, not before and
even then not excessively so that we printk our-selves to death.

I'm not inclined to offer such a patch right now as it feels like it's
fixing a problem nobody has reported.


  --cw

  reply	other threads:[~2004-09-10 23:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-02 19:28 Chris Wedgwood
2004-09-02 19:34 ` William Lee Irwin III
2004-09-02 19:47   ` Chris Wedgwood
2004-09-02 19:52     ` William Lee Irwin III
2004-09-02 19:59       ` Chris Wedgwood
2004-09-02 20:13     ` Nathan Bryant
2004-09-02 19:27       ` Alan Cox
2004-09-02 20:32         ` Chris Wedgwood
2004-09-10 21:23 ` Maciej W. Rozycki
2004-09-10 23:10   ` Chris Wedgwood [this message]
2004-09-10 22:21     ` Alan Cox
2004-09-10 23:28       ` Chris Wedgwood
2004-09-11 13:36         ` Alan Cox
2004-09-11  0:14     ` Maciej W. Rozycki
2004-09-11  0:17       ` Chris Wedgwood
2004-09-11  0:33         ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040910231052.GA3078@taniwha.stupidest.org \
    --to=cw@f00f.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macro@linux-mips.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®