mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <ak@muc.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Kaigai Kohei <kaigai@ak.jp.nec.com>,
	hugh@veritas.com, wli@holomorphy.com,
	takata.hirokazu@renesas.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atomic_inc_return() for i386[1/5] (Re: atomic_inc_return)
Date: 12 Sep 2004 10:25:39 +0200	[thread overview]
Date: Sun, 12 Sep 2004 10:25:38 +0200	[thread overview]
Message-ID: <20040912082538.GA87823@muc.de> (raw)
In-Reply-To: <20040911160532.07216174.akpm@osdl.org>

On Sat, Sep 11, 2004 at 04:05:32PM -0700, Andrew Morton wrote:
> kaigai@ak.jp.nec.com (Kaigai Kohei) wrote:
> >
> > 
> > [1/5] atomic_inc_return-linux-2.6.9-rc1.i386.patch
> >   This patch implements atomic_inc_return() and so on for i386,
> >   and includes runtime check whether CPU is legacy 386.
> >   It is same as I posted to LKML and Andi Kleen at '04/09/01.
> > 
> 
> Can we not use the `alternative instruction' stuff to eliminate the runtime
> test?

Yes, we could. I suggested this to Kaigai-san earlier, but
he decided that it was too complicated because he would have needed
to add an additional alternative() macro with enough parameters.

Given that atomic instructions are quite costly anyways and the jump
should be very predictable he's probably right that it wouldn't 
be worth the effort. 

-Andi

  reply	other threads:[~2004-09-12  8:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.44.0409092005430.14004-100000@localhost.localdomain>
2004-09-10  3:26 ` Kaigai Kohei
2004-09-10  5:34   ` Chris Wedgwood
2004-09-11 23:05   ` Andrew Morton
2004-09-12  8:25     ` Andi Kleen [this message]
2004-09-12  9:06       ` Andrew Morton
2004-09-10  3:27 ` [PATCH] atomic_inc_return() for x86_64[2/5] " Kaigai Kohei
2004-09-10  3:29 ` [PATCH] atomic_inc_return() for arm[3/5] " Kaigai Kohei
2004-09-10  3:30 ` [PATCH] atomic_inc_return() for arm26[1/5] " Kaigai Kohei
2004-09-10  3:32 ` [PATCH] atomic_inc_return() for sparc64[5/5] " Kaigai Kohei
2004-09-10  5:26   ` David S. Miller
2004-09-10  4:05 ` PATCH] atomic_inc_return() [0/5] " Kaigai Kohei
2004-09-10  6:37   ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040912082538.GA87823@muc.de \
    --to=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=hugh@veritas.com \
    --cc=kaigai@ak.jp.nec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=takata.hirokazu@renesas.com \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®