From: Roel van der Made <roel@telegraafnet.nl>
To: Ingo Molnar <mingo@elte.hu>
Cc: Kirill Korotaev <dev@sw.ru>,
linux-kernel@vger.kernel.org, akpm@osdl.org, torvalds@osdl.org,
wli@holomorphy.com
Subject: Re: [PATCH]: Re: kernel 2.6.9-rc1-mm4 oops
Date: Mon, 13 Sep 2004 15:34:38 +0200 [thread overview]
Message-ID: <20040913133437.GW3951@telegraafnet.nl> (raw)
In-Reply-To: <20040913092443.GA19437@elte.hu>
[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]
Hi,
On Mon, Sep 13, 2004 at 11:24:43AM +0200, Ingo Molnar wrote:
> * Kirill Korotaev <dev@sw.ru> wrote:
> > >the BUG() is useful for all the code that uses next_thread() - you can
> > >only do a safe next_thread() iteration if you've locked ->sighand.
> > 1. I don't see spin_lock() on p->sighand->siglock in do_task_stat()
> > before calling next_thread(). And the check inside next_thread() permits
> > only one of the locks to be taken:
> > if (!spin_is_locked(&p->sighand->siglock) &&
> > !rwlock_is_locked(&tasklist_lock))
<snip>
> > the last check ensures that we are still hashed and this check is more
> > straithforward for understanding, agree?
>
> yep - please send a new patch to Andrew.
I'll be awaiting the patch and give it a shot.
Thanks all for the feedback.
--
Roel van der Made .--.
GNU/Linux Systems/Network Engineer |o_o |
Telegraaf Media ICT - Internet Services |:_/ |
Tel.: 020 585 2229 // \ \
GnuPG Key available at: http://roel.net/gpgkey.asc
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-09-13 13:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-12 18:48 Roel van der Made
2004-09-13 8:06 ` [PATCH]: " Kirill Korotaev
2004-09-13 8:05 ` William Lee Irwin III
2004-09-13 8:31 ` Ingo Molnar
2004-09-13 9:15 ` Kirill Korotaev
2004-09-13 9:24 ` Ingo Molnar
2004-09-13 13:34 ` Roel van der Made [this message]
2004-09-13 13:38 ` Ingo Molnar
2004-09-13 13:42 ` Roel van der Made
2004-09-13 15:03 ` Kirill Korotaev
2004-09-13 14:39 ` Kirill Korotaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040913133437.GW3951@telegraafnet.nl \
--to=roel@telegraafnet.nl \
--cc=akpm@osdl.org \
--cc=dev@sw.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@osdl.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®