mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@engr.sgi.com>
To: torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] fix sysrq handling bug in sn_console.c
Date: Mon, 13 Sep 2004 14:23:33 -0700	[thread overview]
Message-ID: <200409131423.33665.jbarnes@engr.sgi.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

Fix a stupid bug in the sysrq handling in sn_console.c.  Instead of eating all 
characters in the sysrq string (preventing them from getting to the tty 
layer), only eat those following 'ESC' since that's a pretty important 
character for various things.  Please apply before 2.6.9 is released as the 
console is very unfriendly to use without it.

Signed-off-by: Jesse Barnes <jbarnes@sgi.com>

Thanks,
Jesse

[-- Attachment #2: sn-console-esc-fix-2.patch --]
[-- Type: text/plain, Size: 895 bytes --]

--- linux-2.5-stock/drivers/serial/sn_console.c	2004-09-10 15:06:37.000000000 -0700
+++ linux-2.6.9-rc1-mm5/drivers/serial/sn_console.c	2004-09-13 14:08:03.000000000 -0700
@@ -596,10 +596,15 @@
                                 sysrq_requested = jiffies;
                                 sysrq_serial_ptr = sysrq_serial_str;
                         }
-			continue; /* ignore the whole sysrq string */
+			/*
+			 * ignore the whole sysrq string except for the
+			 * leading escape
+			 */
+			if (ch != '\e')
+				continue;
                 }
                 else
-                        sysrq_serial_ptr = sysrq_serial_str;
+			sysrq_serial_ptr = sysrq_serial_str;
 #endif /* CONFIG_MAGIC_SYSRQ */
 
 		/* record the character to pass up to the tty layer */
@@ -611,8 +616,6 @@
 			if (tty->flip.count == TTY_FLIPBUF_SIZE)
 				break;
 		}
-		else {
-		}
 		port->sc_port.icount.rx++;
 	}
 

                 reply	other threads:[~2004-09-13 21:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200409131423.33665.jbarnes@engr.sgi.com \
    --to=jbarnes@engr.sgi.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®