mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: Paul P Komkoff Jr <i@stingr.net>
Cc: i@stingr.net, netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RFC] Support for wccp version 1 and 2 in ip_gre.c
Date: Mon, 13 Sep 2004 16:19:12 -0700	[thread overview]
Message-ID: <20040913161912.7dcc809f.davem@davemloft.net> (raw)
In-Reply-To: <20040913051706.GB26337@stingr.sgu.ru>

On Mon, 13 Sep 2004 09:17:06 +0400
Paul P Komkoff Jr <i@stingr.net> wrote:

> Replying to David S. Miller:
> > What are the rules for IP_GRE in general for when
> > to apply this transformation?
> 
> As you can see, I am applying it unconditionally when fits. For most
> cases, this will be OK.
> There can be situations when this is not wanted (for example, when 
> debugging something), so in general, tuning knob will be useful, but 
> I just don't know where to add it, maybe tunnel->parms.i_flags ...

I don't think adding such a knob is necessary, but yes i_flags
would be the place to do it.

I will apply your patch with the "if(1)" simply removed.

Thanks.

  reply	other threads:[~2004-09-13 23:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-11 19:41 Paul P Komkoff Jr
2004-09-13  0:05 ` David S. Miller
2004-09-13  5:17   ` Paul P Komkoff Jr
2004-09-13 23:19     ` David S. Miller [this message]
2004-09-14  8:48       ` Lincoln Dale
2004-09-14 12:39         ` Paul P Komkoff Jr
2004-09-14 13:07           ` Lincoln Dale
2004-09-14 20:12             ` Paul P Komkoff Jr
2004-09-15  5:45         ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040913161912.7dcc809f.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=i@stingr.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome