mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Roland McGrath <roland@redhat.com>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] exec: fix posix-timers leak and pending signal loss
Date: Mon, 13 Sep 2004 17:26:30 -0700	[thread overview]
Message-ID: <20040913172630.249a7aac.akpm@osdl.org> (raw)
In-Reply-To: <200409140021.i8E0LKcB030581@magilla.sf.frob.com>

Roland McGrath <roland@redhat.com> wrote:
>
>  Frankly, I think the old code is much more prone to unforeseen problems
>  than the new.  

It's a question of testing coverage, and historical fragility of that part
of the code.  I'm uncomfortable making changes in there unless we're early
in the release cycle.

>  > Had you not rolled three distinct patches into one (hint) I'd have
>  > forwarded along the leak fix and sat on the rest for post-2.6.9.
> 
>  I don't like being an enabler of bad code.  So I didn't do a separate fix
>  inside something that I already knew needed to be ripped out.  If you want
>  an untested minimal fix for just the leak potential, leaving the semantics
>  frotzed in multiple ways

As long as "frotzed" != "goes oops mysteriously two days after we release
2.6.9" I'm happy.

> you can try the following.

I shall, thanks.

      reply	other threads:[~2004-09-14  0:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-11  7:59 Roland McGrath
2004-09-13 23:26 ` Andrew Morton
2004-09-14  0:21   ` Roland McGrath
2004-09-14  0:26     ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040913172630.249a7aac.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®