From: BlaisorBlade <blaisorblade_spam@yahoo.it>
To: Jeff Dike <jdike@addtoit.com>
Cc: user-mode-linux-devel@lists.sourceforge.net,
David Jeffery <djeffery@britsys.net>,
linux-kernel@vger.kernel.org
Subject: Re: [uml-devel] [PATCH] nptl/sys_clone fix for i386/ppc
Date: Mon, 13 Sep 2004 20:50:08 +0200 [thread overview]
Message-ID: <200409132050.08856.blaisorblade_spam@yahoo.it> (raw)
In-Reply-To: <20040913031014.GA13184@ccure.user-mode-linux.org>
On Monday 13 September 2004 05:10, Jeff Dike wrote:
> On Sun, Sep 12, 2004 at 05:52:44PM +0200, BlaisorBlade wrote:
> > It worked no worse than current version (which is broken). In fact the
> > 2.4 clone had 2 arguments. So it's obvious.
>
> In fact, it worked better. It worked on a modern Debian filesystem, where
> my old code didn't.
Oh, well, your version gets the fifth arg right, indeed.
> > However, this is non-standard. I've added just a comment for now, since
> > you may have reason to keep the current code, but such behaviour calls
> > for breakage when things change.
> Yeah, I not sure why I did things the way I did. That's very old code, and
> there may have been some good reason for it which has since disappeared.
> Offhand, it looks like doing things in the standard way will clean up
> copy_thread a bit.
I agree completely.
--
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
prev parent reply other threads:[~2004-09-13 19:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040826020626.GA28471@malice.crymeariver.org>
[not found] ` <200409111745.18659.blaisorblade_spam@yahoo.it>
[not found] ` <20040911182615.GB2966@ccure.user-mode-linux.org>
2004-09-12 15:52 ` BlaisorBlade
2004-09-13 3:10 ` Jeff Dike
2004-09-13 18:50 ` BlaisorBlade [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200409132050.08856.blaisorblade_spam@yahoo.it \
--to=blaisorblade_spam@yahoo.it \
--cc=djeffery@britsys.net \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®