Re: [patch][2/3] ide: add ide_hwif_t->dma_exec_cmd()

[Bartlomiej Zolnierkiewicz <bzolnier@elka.pw.edu.pl>]

On Monday 13 September 2004 23:35, Jeremy Higdon wrote:
> On Mon, Sep 13, 2004 at 01:33:55AM +0200, Bartlomiej Zolnierkiewicz wrote:
> > 
> > [patch] ide: add ide_hwif_t->dma_exec_cmd()
> > 
> > - split off ->dma_exec_cmd() from ->ide_dma_[read,write] functions
> > - choose command to execute by ->dma_exec_cmd() in higher layers
> >   and remove ->ide_dma_[read,write]
> > 
> > Some real bugs are also fixed:
> > - in Etrax ide.c driver REQ_DRIVE_TASKFILE requests weren't
> >   handled properly for drive->addressing == 0
> > - in trm290.c read and write commands were interchanged
> > - in sgiioc4.c commands weren't sent to disk devices

DMA commands, PIO ones were sent out

> Sgiioc4 only is used with multimedia devices.  I don't think disks will
> work with it, even if you do send commands.

It is hard to believe but if this is true it should be documented somewhere.

Anyway my changes don't make it worse. :-)