From: Greg KH <greg@kroah.com>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: Patch for 3 ub bugs in 2.6.9-rc1-mm4
Date: Tue, 14 Sep 2004 11:55:31 -0700 [thread overview]
Message-ID: <20040914185531.GB20942@kroah.com> (raw)
In-Reply-To: <20040911202525.1fd6c206@lembas.zaitcev.lan>
On Sat, Sep 11, 2004 at 08:25:25PM -0700, Pete Zaitcev wrote:
> Hi, Greg,
>
> Actual users of ub quickly found problems, so here's a patch to address
> some of them.
>
> #1: An attempt to mount a CF card, pull the plug, then unmount causes a
> message "getblk: bad sector size 512" and an oops. This is caused by
> trying to do put_disk from disconnect instead of using a reference count.
> The sd.c does it this way (it uses kref).
>
> #2: The hald fills /var/log/messages with block device errors. It seems
> that it happens because ub allowed opens of known offline devices, and
> then partition checking produced those errors. I hope taking code from
> sd.c should fix it.
>
> Also I replaced usb_unlink_urb with usb_kill_urb.
Applied, thanks.
(oops, you forgot the Signed-off-by: line...)
greg k-h
prev parent reply other threads:[~2004-09-14 20:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-12 3:25 Pete Zaitcev
2004-09-14 18:55 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040914185531.GB20942@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®