From: Pavel Machek <pavel@ucw.cz>
To: kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@zip.com.au>,
Rusty trivial patch monkey Russell <trivial@rustcorp.com.au>
Subject: Untangle code in bio.c
Date: Wed, 15 Sep 2004 13:18:02 +0200 [thread overview]
Message-ID: <20040915111802.GA20222@elf.ucw.cz> (raw)
Hi!
bio.c uses quite ugly code with goto's, completely
unneccessarily. Please apply,
Pavel
--- clean-mm/fs/bio.c 2004-09-15 12:58:10.000000000 +0200
+++ linux-mm/fs/bio.c 2004-09-15 13:00:51.000000000 +0200
@@ -143,7 +143,7 @@
bio = mempool_alloc(bio_pool, gfp_mask);
if (unlikely(!bio))
- goto out;
+ return NULL;
bio_init(bio);
@@ -157,13 +157,11 @@
noiovec:
bio->bi_io_vec = bvl;
bio->bi_destructor = bio_destructor;
-out:
return bio;
}
mempool_free(bio, bio_pool);
- bio = NULL;
- goto out;
+ return NULL;
}
/**
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
next reply other threads:[~2004-09-15 11:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-15 11:18 Pavel Machek [this message]
2004-09-15 11:36 ` Andrew Morton
2004-09-15 11:55 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040915111802.GA20222@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®