mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Henriksson <andreas@fjortis.info>
To: Andrew Morton <akpm@osdl.org>
Cc: adaplas@pol.net, davej@redhat.com, linux-kernel@vger.kernel.org
Subject: [PATCH] fbdev: Remove i810fb explicit agp initialization hack.
Date: Wed, 15 Sep 2004 23:43:28 +0200	[thread overview]
Message-ID: <20040915214328.GA1180@scream.fjortis.info> (raw)


When Antonino A. Daplas posted his "fbdev: Initialize i810fb after agpgart"
patch he said that the ugly agp initialization hack for intel agp shouldn't be
needed but that he couldn't test it.

I have tested the framebuffer updates and additionally removed the
initialization hack and it does indeed work.

Signed-off-by: Andreas Henriksson <andreas@fjortis.info>

--- linux-2.6.9-rc1-mm5/drivers/char/agp/intel-agp.c.old	2004-09-15 23:13:05.000000000 +0200
+++ linux-2.6.9-rc1-mm5/drivers/char/agp/intel-agp.c	2004-09-15 23:13:23.000000000 +0200
@@ -1781,16 +1781,8 @@ static struct pci_driver agp_intel_pci_d
 	.resume		= agp_intel_resume,
 };
 
-/* intel_agp_init() must not be declared static for explicit
-   early initialization to work (ie i810fb) */
-int __init agp_intel_init(void)
+static int __init agp_intel_init(void)
 {
-	static int agp_initialised=0;
-
-	if (agp_initialised == 1)
-		return 0;
-	agp_initialised=1;
-
 	return pci_module_init(&agp_intel_pci_driver);
 }
 

                 reply	other threads:[~2004-09-15 21:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040915214328.GA1180@scream.fjortis.info \
    --to=andreas@fjortis.info \
    --cc=adaplas@pol.net \
    --cc=akpm@osdl.org \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®