From: Andi Kleen <ak@suse.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andi Kleen <ak@suse.de>, Andrew Morton <akpm@osdl.org>,
Zwane Mwaikambo <zwane@fsmlabs.com>,
linux-kernel@vger.kernel.org, wli@holomorphy.com
Subject: Re: [PATCH] remove LOCK_SECTION from x86_64 spin_lock asm
Date: Thu, 16 Sep 2004 11:01:18 +0200 [thread overview]
Message-ID: <20040916090117.GA23621@wotan.suse.de> (raw)
In-Reply-To: <20040916074431.GA13713@elte.hu>
On Thu, Sep 16, 2004 at 09:44:31AM +0200, Ingo Molnar wrote:
>
> * Andi Kleen <ak@suse.de> wrote:
>
> > Something is mixed up here:
> >
> > The whole problem only happens on kernels using frame pointer. I never
> > saw it, simply because I don't use frame pointers.
> >
> > On a frame pointer less kernel profiling works just fine, and with
> > this fix it should work the same on a FP kernel.
>
> it only works on pointer less kernels because the spinlock profile
> unwinding is _conditional_ on an FP kernel right now:
Actually my idea doesn't work because there is a one instruction
race where rbp is not set up on the stack yet. I think I give up and just save
%rbp in this case.
-Andi
next prev parent reply other threads:[~2004-09-16 9:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-15 16:01 Zwane Mwaikambo
2004-09-15 21:45 ` Andrew Morton
2004-09-15 17:55 ` Zwane Mwaikambo
2004-09-15 21:47 ` Ingo Molnar
2004-09-16 6:13 ` Andi Kleen
2004-09-16 6:27 ` Ingo Molnar
2004-09-16 6:44 ` Andi Kleen
2004-09-16 6:51 ` Ingo Molnar
2004-09-16 6:53 ` Andi Kleen
2004-09-16 6:58 ` Ingo Molnar
2004-09-16 7:09 ` Andi Kleen
2004-09-16 7:19 ` Ingo Molnar
2004-09-16 7:29 ` Andi Kleen
2004-09-16 7:44 ` Ingo Molnar
2004-09-16 7:53 ` Andi Kleen
2004-09-16 9:01 ` Andi Kleen [this message]
2004-09-16 12:44 ` Zwane Mwaikambo
2004-09-16 19:30 ` Ingo Molnar
2004-09-15 22:42 Andrew Chew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040916090117.GA23621@wotan.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=wli@holomorphy.com \
--cc=zwane@fsmlabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome