mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Nigel Cunningham <ncunningham@linuxmail.org>
Cc: Andrew Morton <akpm@digeo.com>,
	Patrick Mochel <mochel@digitalimplant.org>,
	Pavel Machek <pavel@ucw.cz>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Suspend2 Merge: Driver model patches 1/2
Date: Fri, 17 Sep 2004 08:23:44 +0100	[thread overview]
Message-ID: <20040917082344.B10537@infradead.org> (raw)
In-Reply-To: <1095332323.3855.159.camel@laptop.cunninghams>; from ncunningham@linuxmail.org on Thu, Sep 16, 2004 at 08:58:44PM +1000

> +struct partial_device_tree default_device_tree =
> +{ 
> +	.dpm_active	= LIST_HEAD_INIT(default_device_tree.dpm_active),
> +	.dpm_off	= LIST_HEAD_INIT(default_device_tree.dpm_off),
> +	.dpm_off_irq	= LIST_HEAD_INIT(default_device_tree.dpm_off_irq),
> +};
> +EXPORT_SYMBOL(default_device_tree);


_never_ exports lists, only accessory funktions.  But honestly please get
some builtin code merged first, then think about making it modular.

We don't want to add random exports just to see them never used later on.

      reply	other threads:[~2004-09-17  7:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-16 10:58 Nigel Cunningham
2004-09-17  7:23 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040917082344.B10537@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@digeo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mochel@digitalimplant.org \
    --cc=ncunningham@linuxmail.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®