mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: Bob Gill <gillb4@telusplanet.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6.9-rc2-bk] Network-related panic on boot
Date: Fri, 17 Sep 2004 15:49:42 -0700	[thread overview]
Message-ID: <20040917154942.39034b0c.davem@davemloft.net> (raw)
In-Reply-To: <1095459971.8786.14.camel@localhost.localdomain>


Already fixed.  Patch below:

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/09/17 11:11:23-07:00 david@gibson.dropbear.id.au 
#   [IPV4]: Initialize newly allocated hash tables in fib_semantics.c
#   
#   When fib_create_info() allocates new hash tables, it neglects to
#   initialize them.  This leads to an oops during boot on at least
#   machine I use.  This patch addresses the problem.
#   
#   Signed-off-by: David Gibson <dwg@au1.ibm.com>
#   Signed-off-by: David S. Miller <davem@davemloft.net>
# 
# net/ipv4/fib_semantics.c
#   2004/09/17 11:11:04-07:00 david@gibson.dropbear.id.au +5 -1
#   [IPV4]: Initialize newly allocated hash tables in fib_semantics.c
#   
#   When fib_create_info() allocates new hash tables, it neglects to
#   initialize them.  This leads to an oops during boot on at least
#   machine I use.  This patch addresses the problem.
#   
#   Signed-off-by: David Gibson <dwg@au1.ibm.com>
#   Signed-off-by: David S. Miller <davem@davemloft.net>
# 
diff -Nru a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c
--- a/net/ipv4/fib_semantics.c	2004-09-17 15:33:41 -07:00
+++ b/net/ipv4/fib_semantics.c	2004-09-17 15:33:41 -07:00
@@ -604,8 +604,12 @@
 		if (!new_info_hash || !new_laddrhash) {
 			fib_hash_free(new_info_hash, bytes);
 			fib_hash_free(new_laddrhash, bytes);
-		} else
+		} else {
+			memset(new_info_hash, 0, bytes);
+			memset(new_laddrhash, 0, bytes);
+
 			fib_hash_move(new_info_hash, new_laddrhash, new_size);
+		}
 
 		if (!fib_hash_size)
 			goto failure;

  reply	other threads:[~2004-09-17 22:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-17 22:26 Bob Gill
2004-09-17 22:49 ` David S. Miller [this message]
2004-09-18  2:25   ` Bob Gill
2004-09-18  3:00     ` Jon Smirl
2004-09-18 15:29       ` Jon Smirl
  -- strict thread matches above, loose matches on Subject: below --
2004-09-17 20:41 walt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040917154942.39034b0c.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=gillb4@telusplanet.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®