mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: Gerd Knorr <kraxel@bytesex.org>
Cc: Andrew Morton <akpm@osdl.org>,
	Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: [patch] v4l: bttv update
Date: Fri, 17 Sep 2004 15:51:05 -0700	[thread overview]
Message-ID: <20040917225105.GA11971@us.ibm.com> (raw)
In-Reply-To: <20040916091505.GA11528@bytesex>

On Thu, Sep 16, 2004 at 11:15:05AM +0200, Gerd Knorr wrote:
>   Hi,
> 
> This update for the bttv driver fixes kernel crashes when capturing
> planar yuv images.  It also added sanity checks for the bt878 risc
> code buffer sizes, adds support for a new tv card and has some minor
> code cleanups.

<snip>

> diff -up linux-2.6.9-rc2/drivers/media/video/bttv-driver.c linux/drivers/media/video/bttv-driver.c
> --- linux-2.6.9-rc2/drivers/media/video/bttv-driver.c	2004-09-14 10:37:08.000000000 +0200
> +++ linux/drivers/media/video/bttv-driver.c	2004-09-16 10:06:33.000000000 +0200
> @@ -1,4 +1,6 @@
>  /*
> +    $Id: bttv-driver.c,v 1.14 2004/09/15 16:15:24 kraxel Exp $
> +
>      bttv - Bt848 frame grabber driver
>      
>      Copyright (C) 1996,97,98 Ralph  Metzler <rjkm@thp.uni-koeln.de>
> @@ -743,8 +745,7 @@ static void set_pll(struct bttv *btv)
>          for (i=0; i<10; i++) {
>  		/*  Let other people run while the PLL stabilizes */
>  		vprintk(".");
> -		set_current_state(TASK_INTERRUPTIBLE);
> -		schedule_timeout(HZ/50);
> +		msleep(10);

My original patch used

msleep(20);

Is there a reason the conversion was changed?

-Nish

  reply	other threads:[~2004-09-17 22:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-16  9:15 Gerd Knorr
2004-09-17 22:51 ` Nishanth Aravamudan [this message]
2004-09-20  9:11   ` Gerd Knorr
2005-01-20 15:28 Gerd Knorr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040917225105.GA11971@us.ibm.com \
    --to=nacc@us.ibm.com \
    --cc=akpm@osdl.org \
    --cc=kraxel@bytesex.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome