From: William Lee Irwin III <wli@holomorphy.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
Hugh Dickins <hugh@veritas.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix missing unlock_page in mm/rmap.c
Date: Sat, 18 Sep 2004 04:41:59 -0700 [thread overview]
Message-ID: <20040918114159.GM9106@holomorphy.com> (raw)
In-Reply-To: <414C1390.6050802@yahoo.com.au>
On Sat, Sep 18, 2004 at 08:53:04PM +1000, Nick Piggin wrote:
> Please apply.
> A required unlock_page will be missed in a very rare (but possible) race
> condition. Acked by Hugh, who says:
> It'll be hard to hit because of the additional page_mapped test above,
> with truncate unmapping ptes from mms before it advances to removing
> pages from cache; but nothing to prevent it happening.
> Signed-off-by: Nick Piggin <nickpiggin@yahoo.com.au>
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
I've hit a missing unlock_page(). I'll see if this fixed it.
-- wli
prev parent reply other threads:[~2004-09-18 11:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-18 10:53 Nick Piggin
2004-09-18 11:41 ` William Lee Irwin III [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040918114159.GM9106@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@osdl.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®