mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: linux-kernel@vger.kernel.org
Subject: The new PCI fixup code ate my IDE controller
Date: Wed, 22 Sep 2004 18:49:29 +0100	[thread overview]
Message-ID: <20040922174929.GP16153@parcelfarce.linux.theplanet.co.uk> (raw)


The new DECLARE_PCI_FIXUP_HEADER() now makes the order of fixups depend
on link order.  This is a bad thing because it's now one more thing that
link order is used to determine.  Eventually, we're going to have a knot
where you can't move link order to make everything work.

The specific problem here is that quirk_ide_bases() is called before
superio_fixup_pci().  This is only a problem on PA-RISC.  I can see
a few solutions to this.  First, we can move the whole suckyio driver
to arch/parisc, ensuring it gets linked before drivers/pci.  Second,
just move the DECLARE_PCI_FIXUP_HEADER to arch/parisc.  Third, link
drivers/parisc ahead of drivers/pci (what other fun ordering problems
might we have?)  Fourth, move the IDE quirk from drivers/pci/quirks.c
to drivers/ide somewhere (which is linked after drivers/parisc so would
happen to fix our problem).  Fifth, back out the quirk changes.  Sixth,
change the pci fixup stuff to sort the quirks by vendor ID (PCI_ANY_ID
sorts after any other ID).

Suggestions?

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

             reply	other threads:[~2004-09-22 17:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-22 17:49 Matthew Wilcox [this message]
2004-09-22 18:19 ` David Woodhouse
2004-09-22 18:39   ` Matthew Wilcox
2004-09-22 19:28     ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040922174929.GP16153@parcelfarce.linux.theplanet.co.uk \
    --to=matthew@wil.cx \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®