From: Andrew Morton <akpm@osdl.org>
To: janitor@sternwelten.at
Cc: linux-kernel@vger.kernel.org, janitor@sternwelten.at, nacc@us.ibm.com
Subject: Re: [patch 12/26] char/istallion: replace schedule_timeout() with msleep_interruptible()
Date: Thu, 23 Sep 2004 15:30:27 -0700 [thread overview]
Message-ID: <20040923153027.36a2eedd.akpm@osdl.org> (raw)
In-Reply-To: <E1CAa9g-0008HI-0z@sputnik>
janitor@sternwelten.at wrote:
>
> @@ -2504,7 +2484,8 @@ static void stli_waituntilsent(struct tt
> while (test_bit(ST_TXBUSY, &portp->state)) {
> if (signal_pending(current))
> break;
> - stli_delay(2);
> + set_current_state(TASK_INTERRUPTIBLE);
> + schedule_timeout(2);
> if (time_after_eq(jiffies, tend))
> break;
> }
I'll replace this with msleep_interruptible(20), which is presumably what
the driver was trying to do originally.
Again, all of these delays become accidental busyloops if the calling task
has a signal pending. Sigh. Probably they should all be using
TASK_UNINTERRUPTIBLE.
prev parent reply other threads:[~2004-09-23 22:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-23 20:25 janitor
2004-09-23 22:30 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040923153027.36a2eedd.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=janitor@sternwelten.at \
--cc=linux-kernel@vger.kernel.org \
--cc=nacc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®