mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: William Lee Irwin III <wli@holomorphy.com>
To: Albert Cahalan <albert@users.sf.net>
Cc: linux-kernel mailing list <linux-kernel@vger.kernel.org>,
	rth@twiddle.net
Subject: Re: __attribute__((always_inline)) fiasco
Date: Thu, 23 Sep 2004 09:50:26 -0700	[thread overview]
Message-ID: <20040923165026.GF9106@holomorphy.com> (raw)
In-Reply-To: <1095956778.4966.940.camel@cube>

On Thu, Sep 23, 2004 at 12:26:18PM -0400, Albert Cahalan wrote:
> #define INLINE
> #define INLINE inline
> #define INLINE static inline  // an oxymoron
> #define INLINE extern inline  // an oxymoron
> #define INLINE __force_inline
> #define INLINE __attribute__((always_inline))
> #define INLINE _Pragma("inline")
> #define INLINE __inline_or_die_you_foul_compiler
> #define INLINE _Please inline

The // apart from being a C++ ism (screw C99; it's still non-idiomatic)
will cause spurious ignorance of the remainder of the line, which is
often very important. e.g.

static INLINE int lock_need_resched(spinlock_t *lock)
{
	...


-- wli

  reply	other threads:[~2004-09-23 16:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-23 16:26 Albert Cahalan
2004-09-23 16:50 ` William Lee Irwin III [this message]
2004-09-23 16:59   ` Albert Cahalan
2004-09-23 17:03   ` Richard Henderson
2004-09-23 17:21   ` viro
2004-09-23 17:33     ` William Lee Irwin III
2004-09-23 17:39       ` viro
2004-09-26  1:29   ` Tonnerre
2004-09-26  2:05     ` William Lee Irwin III
2004-09-30 16:19       ` Bill Davidsen
2004-09-23 16:54 ` Richard Henderson
2004-09-23 17:46   ` Albert Cahalan
  -- strict thread matches above, loose matches on Subject: below --
2004-09-23  8:47 Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040923165026.GF9106@holomorphy.com \
    --to=wli@holomorphy.com \
    --cc=albert@users.sf.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®