mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Hanna Linder <hannal@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@lists.osdl.org,
	davej@codemonkey.org.uk, hpa@zytor.com
Subject: Re: [PATCH 2.6.9-rc2-mm2] Create new function to see if pci dev is present
Date: Thu, 23 Sep 2004 15:50:35 -0700	[thread overview]
Message-ID: <20040923225035.GB14274@kroah.com> (raw)
In-Reply-To: <2480000.1095978400@w-hlinder.beaverton.ibm.com>

On Thu, Sep 23, 2004 at 03:26:40PM -0700, Hanna Linder wrote:
> + * @from: Previous PCI device found in search, or %NULL for new search.

from is not needed in a function like this.  Just vendor and device
should work.

> +static inline int pci_dev_present(unsigned int vendor, unsigned int device, struct pci_dev *from)
> +{return -1; }
> +

This should return 0, not -1.

Care to redo your patches based on this?

thanks,

greg k-h

  reply	other threads:[~2004-09-23 23:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-23 22:26 Hanna Linder
2004-09-23 22:50 ` Greg KH [this message]
2004-09-24 19:02 ` Christoph Hellwig
2004-09-24 21:19   ` Greg KH
2004-09-24 21:00     ` Alan Cox
2004-09-26 14:10       ` Greg KH
2004-09-28 17:24         ` Greg KH
2004-09-28 17:25           ` Greg KH
2004-09-28 17:26           ` Greg KH
2004-09-24 21:26     ` [PATCH 2.6.9-rc2-mm2] " H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040923225035.GB14274@kroah.com \
    --to=greg@kroah.com \
    --cc=davej@codemonkey.org.uk \
    --cc=hannal@us.ibm.com \
    --cc=hpa@zytor.com \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome