From: Christoph Hellwig <hch@infradead.org>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: "Leubner, Achim" <Achim_Leubner@adaptec.com>,
arjanv@redhat.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gdth update
Date: Wed, 29 Sep 2004 15:21:09 +0100 [thread overview]
Message-ID: <20040929152109.A13189@infradead.org> (raw)
In-Reply-To: <20040929134301.GB17952@wohnheim.fh-wedel.de>; from joern@wohnheim.fh-wedel.de on Wed, Sep 29, 2004 at 03:43:01PM +0200
On Wed, Sep 29, 2004 at 03:43:01PM +0200, Jörn Engel wrote:
> On Wed, 29 September 2004 14:15:57 +0200, Leubner, Achim wrote:
> >
> > > > +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,0)
> > > > +static irqreturn_t gdth_interrupt(int irq, void *dev_id, struct
> > pt_regs *regs);
> > > > #else
> > > > -static void gdth_interrupt(int irq,struct pt_regs *regs);
> > > > +static void gdth_interrupt(int irq, void *dev_id, struct pt_regs
> > *regs);
> > > > #endif
> > >
> > > this really is the wrong way to do such irq prototype compatibility in
> > > drivers. *really*
> > >
> > So please tell me what the right way should be. It works without any
> > problem.
>
> #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,0)
> #define irqreturn_t void
> #define IRQ_NONE
> #define IRQ_HANDLED
> #endif
Actually all these are in recent 2.4.x release. So better check for
#ifndef IRQ_HANDLED.
next prev parent reply other threads:[~2004-09-29 14:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-29 12:15 Leubner, Achim
2004-09-29 12:41 ` Christoph Hellwig
2004-09-29 13:43 ` Jörn Engel
2004-09-29 14:21 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-09-29 14:28 Leubner, Achim
[not found] <200409281401.i8SE1dXL006887@hera.kernel.org>
2004-09-29 11:42 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040929152109.A13189@infradead.org \
--to=hch@infradead.org \
--cc=Achim_Leubner@adaptec.com \
--cc=arjanv@redhat.com \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®