From: Andrew Morton <akpm@osdl.org>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: zwane@linuxpower.ca, jgarzik@pobox.com,
linux-kernel@vger.kernel.org, asit.k.mallick@intel.com,
ak@suse.de
Subject: Re: [Patch 0/2] Disable SW irqbalance/irqaffinity for E7520/E7320/E7525
Date: Thu, 30 Sep 2004 15:51:34 -0700 [thread overview]
Message-ID: <20040930155134.35cf1235.akpm@osdl.org> (raw)
In-Reply-To: <20040928141157.D18131@unix-os.sc.intel.com>
Suresh Siddha <suresh.b.siddha@intel.com> wrote:
>
> --- linux-2.6.9-rc2/drivers/pci/quirks.c 2004-09-12 22:31:27.000000000 -0700
> +++ linux-irq/drivers/pci/quirks.c 2004-09-08 18:20:59.794026624 -0700
> @@ -814,6 +814,55 @@
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801DB_12, asus_hides_smbus_lpc );
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801EB_0, asus_hides_smbus_lpc );
>
> +#if defined(CONFIG_X86_IO_APIC) && defined(CONFIG_SMP)
> +#include <asm/hw_irq.h>
> +#ifdef CONFIG_IRQBALANCE
> +extern int irqbalance_disable(char *str);
> +#endif
> +extern int no_irq_affinity;
> +extern int noirqdebug_setup(char *str);
Please don't put extern declarations in .c files. Try to find a suitable
header file which is included by both the definition and the users of these
variables/functions.
If there is no appropriate header file, feel free to create a new one.
next prev parent reply other threads:[~2004-09-30 22:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-24 6:34 Suresh Siddha
2004-09-24 15:05 ` Zwane Mwaikambo
2004-09-24 20:24 ` Jeff Garzik
2004-09-24 22:20 ` Suresh Siddha
2004-09-25 9:15 ` Zwane Mwaikambo
2004-09-27 18:03 ` Suresh Siddha
2004-09-28 21:11 ` Suresh Siddha
2004-09-29 15:16 ` Zwane Mwaikambo
2004-09-30 22:51 ` Andrew Morton [this message]
2004-10-01 1:15 ` Suresh Siddha
2004-09-29 13:36 ` Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040930155134.35cf1235.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@suse.de \
--cc=asit.k.mallick@intel.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome