From: Chris Wright <chrisw@osdl.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Chris Wright <chrisw@osdl.org>,
torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] mlockall(MCL_FUTURE) unlocks currently locked mappings
Date: Thu, 30 Sep 2004 17:22:59 -0700 [thread overview]
Message-ID: <20040930172259.Y1924@build.pdx.osdl.net> (raw)
In-Reply-To: <20040930164744.30db3fdc.akpm@osdl.org>; from akpm@osdl.org on Thu, Sep 30, 2004 at 04:47:44PM -0700
* Andrew Morton (akpm@osdl.org) wrote:
> Chris Wright <chrisw@osdl.org> wrote:
> >
> > Calling mlockall(MCL_FUTURE) will erroneously unlock any currently locked
> > mappings. Fix this up, and while we're at it, remove the essentially
> > unused error variable.
>
> eek.
>
> I've always assumed that mlockall(MCL_FUTURE) pins all your current pages
> as well as future ones. But no, that's what MCL_CURRENT|MCL_FUTURE does.
>
> So when we fix this bug, we'll break my buggy test apps.
>
> I wonder what other apps we'll break?
I don't think it will break apps. The only difference is that it won't
unlock already locked mappings.
thanks,
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
next prev parent reply other threads:[~2004-10-01 0:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-29 18:42 Chris Wright
2004-09-29 18:45 ` [PATCH 2/4] mlockall() check rlimit only when MCL_CURRENT is set Chris Wright
2004-09-29 18:47 ` [PATCH 3/4] make can_do_mlock useful for mlock/mlockall Chris Wright
2004-09-29 18:49 ` [PATCH 4/4] mlockall() take mmap_sem a bit later Chris Wright
2004-09-30 23:47 ` [PATCH 1/4] mlockall(MCL_FUTURE) unlocks currently locked mappings Andrew Morton
2004-10-01 0:22 ` Chris Wright [this message]
2004-10-01 0:58 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040930172259.Y1924@build.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®