mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Matthew Dobson <colpatch@us.ibm.com>
Cc: Andi Kleen <ak@suse.de>, Nick Piggin <nickpiggin@yahoo.com.au>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>,
	"Martin J. Bligh" <mbligh@aracnet.com>
Subject: Re: [RFC PATCH] sched_domains: Make SD_NODE_INIT per-arch
Date: Thu, 30 Sep 2004 23:12:28 +0200	[thread overview]
Message-ID: <20040930211228.GE28315@wotan.suse.de> (raw)
In-Reply-To: <1096578415.20964.9.camel@arrakis>

> Well, you can certainly base the x86_64 CMP values on the current
> SD_SIBLING_INIT values.  Those are well publicized, see
> include/linux/sched.h! ;)

Current BK has it in kernel/sched.c.

And it also broke NUMA kernels on UP, but that's a different issue.

> I suppose it would be pretty trivial to define defaults in
> include/asm-generic/topology.h, and allow arches that care to define
> their own SD_*_INITs without disrupting anyone else.  Actually, that's
> far better than what I've got now.  I'll run that patch up after the
> meeting I'm currently late for and post it in a couple hours.

Full override isn't good imho because it could lead to bit rot, 
better is to have defaults that can be used as a base, but tweaked.


-Andi

  reply	other threads:[~2004-09-30 21:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-29  1:12 Matthew Dobson
2004-09-30  8:15 ` Nick Piggin
2004-09-30 18:36   ` Matthew Dobson
2004-09-30 19:23     ` Andrew Morton
2004-09-30 20:20       ` Matthew Dobson
2004-10-01  6:15       ` Martin J. Bligh
2004-10-01 22:20         ` Matthew Dobson
2004-10-02 16:02           ` Martin J. Bligh
2004-09-30 20:45     ` Andi Kleen
2004-09-30 21:06       ` Matthew Dobson
2004-09-30 21:12         ` Andi Kleen [this message]
2004-09-30 23:47           ` Matthew Dobson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040930211228.GE28315@wotan.suse.de \
    --to=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=colpatch@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbligh@aracnet.com \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®