mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: torvalds@transmeta.com, Andrew Morton <akpm@zip.com.au>,
	Patrick Mochel <mochel@digitalimplant.org>,
	kernel list <linux-kernel@vger.kernel.org>
Subject: swsusp: fix highmem corruption in -rc3
Date: Fri, 1 Oct 2004 13:28:47 +0200	[thread overview]
Message-ID: <20041001112846.GA1489@elf.ucw.cz> (raw)

Hi!

-rc3 swsusp breaks badly with highmem, because patch from -mm is
missing. Please apply this patch from -mm to vanilla.

Otherwise -rc3 swsusp seems to work here... Quite good result for so
big merge. Thanks. (But this certainly scared me a lot).
								Pavel

--- clean/kernel/power/swsusp.c	2004-10-01 00:30:32.000000000 +0200
+++ clean-mm/kernel/power/swsusp.c	2004-09-26 01:34:27.000000000 +0200
@@ -856,7 +860,9 @@
 	local_irq_disable();
 	save_processor_state();
 	error = swsusp_arch_suspend();
+	/* Restore control flow magically appears here */
 	restore_processor_state();
+	restore_highmem();
 	local_irq_enable();
 	return error;
 }
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!

                 reply	other threads:[~2004-10-01 11:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041001112846.GA1489@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=akpm@zip.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mochel@digitalimplant.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®