mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: Ivan Kalatchev <ivan.kalatchev@esg.ca>
Cc: linux-kernel@vger.kernel.org
Subject: Re: kernel 2.6.8 bug in fs/locks.c
Date: Fri, 1 Oct 2004 12:23:33 -0700	[thread overview]
Message-ID: <20041001122332.E1973@build.pdx.osdl.net> (raw)
In-Reply-To: <000001c4a7d3$21c62bb0$2e646434@ivans>; from ivan.kalatchev@esg.ca on Fri, Oct 01, 2004 at 12:24:30PM -0400

* Ivan Kalatchev (ivan.kalatchev@esg.ca) wrote:
> I'm using pthreads for each user-application connections. To protect
> configuration file from corruption I used file locking mechanism - fcntl
> with F_WRLCK/F_RDLCK.

I must be confused.  pthreads and fcntl locking...that does't give
proper exclusion?  The BUG, however, is no good.  Despite the fact
that it appears to come at the result of an application bug, we should
be able to handle this w/out a BUG.  AFAICT, one thread has closed the
file descriptor, whilst another is mucking with the locks.  So the locker
winds up holding the last ref to the filp.  This blows the logic of when
locks_remove_posix gets called.  Thanks for the bug report.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net

  reply	other threads:[~2004-10-01 19:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-01 16:24 Ivan Kalatchev
2004-10-01 19:23 ` Chris Wright [this message]
2004-10-02  0:52   ` [TEST PATCH] " Chris Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041001122332.E1973@build.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=ivan.kalatchev@esg.ca \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®