From: Arnd Bergmann <arnd@arndb.de>
To: Roland Dreier <roland@topspin.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: proper way to annotate kernel use of sys_xxx?
Date: Tue, 5 Oct 2004 10:32:33 +0200 [thread overview]
Message-ID: <200410051032.39531.arnd@arndb.de> (raw)
In-Reply-To: <52u0t9u414.fsf@topspin.com>
[-- Attachment #1: Type: text/plain, Size: 497 bytes --]
On Dienstag, 5. Oktober 2004 07:28, Roland Dreier wrote:
> This is an abuse of sys_open(), but we know it's OK. Is the right way
> to shut up sparse to just change it to:
>
> fd = sys_open((const char __user *) path, 0, 0);
>
No, that's wrong, see
http://marc.theaimsgroup.com/?l=linux-kernel&m=108697882525067 ;-)
In this case, you can easily convert the calls to use
filp_open/vfs_read/filp_close, though I'm not sure if that's
the correct solution either.
Arnd <><
[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-10-05 8:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-05 5:28 Roland Dreier
2004-10-05 8:32 ` Arnd Bergmann [this message]
2004-10-05 17:23 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200410051032.39531.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@topspin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome