From: Pavel Machek <pavel@suse.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@zip.com.au>,
agruen@suse.de
Subject: Fix random crashes in x86-64 swsusp
Date: Thu, 7 Oct 2004 00:06:00 +0200 [thread overview]
Message-ID: <20041006220600.GB25059@elf.ucw.cz> (raw)
In-Reply-To: <200410062346.29489.rjw@sisk.pl>
Hi!
fix_processor_context was calling functions marked __init on x86-64;
bad idea. Maybe we should memset freed memory to zero so such bugs are
prevented?
Thanks to Rafael for keeping notifying me about this bug, and someone
get me yet another brown paper bag.
Anyway, this should fix it, please apply,
Pavel
--- clean-suse/arch/x86_64/ia32/syscall32.c 2004-06-22 12:36:00.000000000 +0200
+++ linux-suse/arch/x86_64/ia32/syscall32.c 2004-10-06 23:58:27.000000000 +0200
@@ -76,7 +76,8 @@
__initcall(init_syscall32);
-void __init syscall32_cpu_init(void)
+/* May not be __init: called during resume */
+void syscall32_cpu_init(void)
{
if (use_sysenter < 0)
use_sysenter = (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL);
--- clean-suse/arch/x86_64/kernel/setup64.c 2004-10-05 11:36:21.000000000 +0200
+++ linux-suse/arch/x86_64/kernel/setup64.c 2004-10-06 23:59:08.000000000 +0200
@@ -195,7 +195,8 @@
char boot_exception_stacks[N_EXCEPTION_STACKS * EXCEPTION_STKSZ]
__attribute__((section(".bss.page_aligned")));
-void __init syscall_init(void)
+/* May not be marked __init: used by software suspend */
+void syscall_init(void)
{
/*
* LSTAR and STAR live in a bit strange symbiosis.
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
next prev parent reply other threads:[~2004-10-06 22:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-05 21:14 2.6.9-rc3[+recent swsusp patches]: swsusp kernel-preemption-unfriendly? Rafael J. Wysocki
2004-10-05 21:27 ` Pavel Machek
2004-10-06 8:55 ` Rafael J. Wysocki
2004-10-06 8:54 ` Pavel Machek
2004-10-06 10:06 ` Rafael J. Wysocki
2004-10-06 10:12 ` Pavel Machek
2004-10-06 21:46 ` Rafael J. Wysocki
2004-10-06 22:06 ` Pavel Machek [this message]
2004-10-06 22:13 ` [kernel] Fix random crashes in x86-64 swsusp Andi Kleen
2004-10-06 22:25 ` Andrew Morton
2004-10-06 22:24 ` Pavel Machek
2004-10-08 20:59 ` swsusp: 8-order memory allocations problem (was: Re: Fix random crashes in x86-64 swsusp) Rafael J. Wysocki
2004-10-10 13:48 ` Pavel Machek
2004-10-10 18:28 ` Andrew Morton
2004-10-13 17:24 ` Rafael J. Wysocki
2004-10-14 15:37 ` swsusp: 8-order memory allocations problem (update) Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041006220600.GB25059@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=agruen@suse.de \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®