From: Andrew Morton <akpm@osdl.org>
To: Ian Campbell <icampbell@arcom.com>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org,
trivial@rustcorp.com.au,
Patrick Mochel <mochel@digitalimplant.org>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH] trivial fix for warning in kernel/power/console.c
Date: Thu, 7 Oct 2004 16:08:58 -0700 [thread overview]
Message-ID: <20041007160858.0708e968.akpm@osdl.org> (raw)
In-Reply-To: <1097157857.5231.10.camel@icampbell-debian>
Ian Campbell <icampbell@arcom.com> wrote:
>
> orig_fgconsole and orig_kmsg are only used in kernel/power/console.c if
> SUSPEND_CONSOLE is defined.
>
> Signed-off-by: Ian Campbell <icampbell@arcom.com>
>
> Index: 2.6-bk/kernel/power/console.c
> ===================================================================
> --- 2.6-bk.orig/kernel/power/console.c 2004-10-07 14:47:25.764724497 +0100
> +++ 2.6-bk/kernel/power/console.c 2004-10-07 14:47:54.241016791 +0100
> @@ -11,7 +11,9 @@
>
> static int new_loglevel = 10;
> static int orig_loglevel;
> +#ifdef SUSPEND_CONSOLE
> static int orig_fgconsole, orig_kmsg;
> +#endif
Not only that, orig_kmsg is assigned to but never read from.
next prev parent reply other threads:[~2004-10-07 23:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-07 14:04 Ian Campbell
2004-10-07 23:08 ` Andrew Morton [this message]
2004-10-08 8:07 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041007160858.0708e968.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=icampbell@arcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@digitalimplant.org \
--cc=pavel@ucw.cz \
--cc=torvalds@osdl.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome