From: Matthew Wilcox <matthew@wil.cx>
To: Scott Feldman <sfeldma@pobox.com>
Cc: Hanna Linder <hannal@us.ibm.com>,
kernel-janitors <kernel-janitors@lists.osdl.org>,
ak@suse.de, lkml <linux-kernel@vger.kernel.org>,
greg@kroah.com
Subject: Re: [KJ] [RFT 2.6] pci-gart.c replace pci_find_device with pci_get_device
Date: Sat, 9 Oct 2004 19:18:59 +0100 [thread overview]
Message-ID: <20041009181859.GW16153@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <1097342134.3903.14.camel@sfeldma-mobl2.dsl-verizon.net>
On Sat, Oct 09, 2004 at 10:15:34AM -0700, Scott Feldman wrote:
> On Fri, 2004-10-08 at 15:55, Hanna Linder wrote:
> > @@ -81,7 +81,7 @@ static u32 gart_unmapped_entry;
> >
> > #define for_all_nb(dev) \
> > dev = NULL; \
> > - while ((dev = pci_find_device(PCI_VENDOR_ID_AMD, 0x1103, dev))!=NULL)\
> > + while ((dev = pci_get_device(PCI_VENDOR_ID_AMD, 0x1103, dev))!=NULL)\
> > if (dev->bus->number == 0 && \
> > (PCI_SLOT(dev->devfn) >= 24) && (PCI_SLOT(dev->devfn) <= 31))
>
> for_each_pci_dev?
for_each_pci_dev() doesn't take a VENDOR/DEVICE ID pair.
I think this is a mistake.
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
next prev parent reply other threads:[~2004-10-09 18:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-08 22:55 Hanna Linder
2004-10-09 17:15 ` [KJ] " Scott Feldman
2004-10-09 18:18 ` Matthew Wilcox [this message]
2004-10-09 21:35 ` Scott Feldman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041009181859.GW16153@parcelfarce.linux.theplanet.co.uk \
--to=matthew@wil.cx \
--cc=ak@suse.de \
--cc=greg@kroah.com \
--cc=hannal@us.ibm.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfeldma@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®