From: Chuck Ebbert <76306.1226@compuserve.com>
To: Michael Schierl <schierlm@gmx.de>
Cc: Joel Becker <joel.becker@oracle.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] softdog.c (was: Kernel panic after rmmod softdog (2.6.8.1))
Date: Mon, 11 Oct 2004 13:01:34 -0400 [thread overview]
Message-ID: <200410111304_MC3-1-8C02-813F@compuserve.com> (raw)
Michael Schierl wrote:
> today, when testing the software watchdog, I accidentally removed the
> software watchdog kernel module and got a kernel panic.
Does this fix it? (compiled but not tested)
--- linux-2.6.8.1/drivers/char/watchdog/softdog.c.orig Sun Oct 10 23:08:24 2004
+++ linux-2.6.8.1/drivers/char/watchdog/softdog.c Sun Oct 10 23:10:12 2004
@@ -135,8 +135,9 @@
{
if(test_and_set_bit(0, &timer_alive))
return -EBUSY;
- if (nowayout)
- __module_get(THIS_MODULE);
+
+ __module_get(THIS_MODULE);
+
/*
* Activate timer
*/
@@ -152,6 +153,7 @@
*/
if (expect_close == 42) {
softdog_stop();
+ module_put(THIS_MODULE);
} else {
printk(KERN_CRIT PFX "Unexpected close, not stopping watchdog!\n");
softdog_keepalive();
--Chuck Ebbert 11-Oct-04 12:49:45
Current book: Stephen King: Wizard and Glass
next reply other threads:[~2004-10-11 17:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-11 17:01 Chuck Ebbert [this message]
2004-10-11 20:00 ` Arnd Bergmann
2004-10-13 23:55 Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200410111304_MC3-1-8C02-813F@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=joel.becker@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schierlm@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome