From: Paul Mundt <paul.mundt@nokia.com>
To: Andrew Morton <akpm@osdl.org>
Cc: nico@cam.org, takata@linux-m32r.org, linux-kernel@vger.kernel.org
Subject: [PATCH] net: fix smc91x build for sh/ppc
Date: Tue, 12 Oct 2004 19:16:32 +0300 [thread overview]
Message-ID: <20041012161631.GA8766@hed040-158.research.nokia.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 965 bytes --]
The current smc91x code uses set_irq_type(). It looks like the m32r guys
worked around this by adding a !defined(__m32r__) check, but this is equally
bogus as set_irq_type() is an arm/arm26-specific function.
Trying to get this to build on sh died in the same spot, so we just back out
the m32r change and make it depend on CONFIG_ARM instead. Notably, the ppc
build would have been broken by this as well, but it doesn't seem like anyone
noticed this there yet.
Signed-off-by: Paul Mundt <paul.mundt@nokia.com>
drivers/net/smc91x.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
===== drivers/net/smc91x.c 1.7 vs edited =====
--- 1.7/drivers/net/smc91x.c 2004-09-17 03:07:00 +03:00
+++ edited/drivers/net/smc91x.c 2004-10-12 19:05:25 +03:00
@@ -1885,7 +1885,7 @@
if (retval)
goto err_out;
-#if !defined(__m32r__)
+#ifdef CONFIG_ARM
set_irq_type(dev->irq, IRQT_RISING);
#endif
#ifdef SMC_USE_PXA_DMA
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next reply other threads:[~2004-10-12 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-12 16:16 Paul Mundt [this message]
2004-10-12 16:26 ` Nicolas Pitre
2004-10-13 1:09 ` Hirokazu Takata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041012161631.GA8766@hed040-158.research.nokia.com \
--to=paul.mundt@nokia.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nico@cam.org \
--cc=takata@linux-m32r.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®